Since the libvirt SASL config file defaults to using GSSAPI (Kerberos), a
config change is rquired to enable plain password auth. This is done by
@@ -10,10 +10,10 @@ diff -urp libvirt-4.5.0.orig/docs/auth.html libvirt-4.5.0/docs/auth.html
parameter to scram-sha-1.
-diff -urp libvirt-4.5.0.orig/docs/auth.html.in libvirt-4.5.0/docs/auth.html.in ---- libvirt-4.5.0.orig/docs/auth.html.in 2018-07-09 16:24:49.471875584 +0000 -+++ libvirt-4.5.0/docs/auth.html.in 2018-07-09 16:25:07.307874521 +0000 -@@ -267,7 +267,7 @@ to turn on SASL auth in these listeners. +diff -urp libvirt-5.3.0.orig/docs/auth.html.in libvirt-5.3.0/docs/auth.html.in +--- libvirt-5.3.0.orig/docs/auth.html.in 2019-02-26 00:24:58.954183786 +0100 ++++ libvirt-5.3.0/docs/auth.html.in 2019-05-06 14:07:53.494000000 +0200 +@@ -277,7 +277,7 @@ to turn on SASL auth in these listeners.
Since the libvirt SASL config file defaults to using GSSAPI (Kerberos), a
config change is rquired to enable plain password auth. This is done by
@@ -22,31 +22,22 @@ diff -urp libvirt-4.5.0.orig/docs/auth.html.in libvirt-4.5.0/docs/auth.html.in
parameter to scram-sha-1.
-diff -urp libvirt-4.5.0.orig/src/Makefile.in libvirt-4.5.0/src/Makefile.in ---- libvirt-4.5.0.orig/src/Makefile.in 2018-07-09 16:24:49.542875580 +0000 -+++ libvirt-4.5.0/src/Makefile.in 2018-07-09 16:25:07.311874521 +0000 -@@ -13166,13 +13166,13 @@ lxc/lxc_controller_dispatch.h: $(srcdir) +diff -urp libvirt-5.3.0.orig/src/Makefile.in libvirt-5.3.0/src/Makefile.in +--- libvirt-5.3.0.orig/src/Makefile.in 2019-05-04 19:53:42.037199636 +0200 ++++ libvirt-5.3.0/src/Makefile.in 2019-05-06 14:07:53.497000000 +0200 +@@ -6271,7 +6271,7 @@ REMOTE_DRIVER_PROTOCOL = \ + # This is needed for clients too, so can't wrap in # the WITH_LIBVIRTD conditional - @WITH_SASL_TRUE@install-sasl: --@WITH_SASL_TRUE@ $(MKDIR_P) $(DESTDIR)$(sysconfdir)/sasl2/ -+@WITH_SASL_TRUE@ $(MKDIR_P) $(DESTDIR)$(sysconfdir)/sasl/ - @WITH_SASL_TRUE@ $(INSTALL_DATA) $(srcdir)/remote/libvirtd.sasl \ --@WITH_SASL_TRUE@ $(DESTDIR)$(sysconfdir)/sasl2/libvirt.conf -+@WITH_SASL_TRUE@ $(DESTDIR)$(sysconfdir)/sasl/libvirt.conf - - @WITH_SASL_TRUE@uninstall-sasl: --@WITH_SASL_TRUE@ rm -f $(DESTDIR)$(sysconfdir)/sasl2/libvirt.conf --@WITH_SASL_TRUE@ rmdir $(DESTDIR)$(sysconfdir)/sasl2/ || : -+@WITH_SASL_TRUE@ rm -f $(DESTDIR)$(sysconfdir)/sasl/libvirt.conf -+@WITH_SASL_TRUE@ rmdir $(DESTDIR)$(sysconfdir)/sasl/ || : - @WITH_SASL_FALSE@install-sasl: - @WITH_SASL_FALSE@uninstall-sasl: - -diff -urp libvirt-4.5.0.orig/src/qemu/qemu.conf libvirt-4.5.0/src/qemu/qemu.conf ---- libvirt-4.5.0.orig/src/qemu/qemu.conf 2018-07-09 16:24:49.520875581 +0000 -+++ libvirt-4.5.0/src/qemu/qemu.conf 2018-07-09 16:25:07.311874521 +0000 -@@ -129,18 +129,18 @@ +-@WITH_SASL_TRUE@sasldir = $(sysconfdir)/sasl2 ++@WITH_SASL_TRUE@sasldir = $(sysconfdir)/sasl + THREAD_LIBS = $(LIB_PTHREAD) $(LTLIBMULTITHREAD) + SECDRIVER_CFLAGS = $(am__append_191) $(am__append_193) + SECDRIVER_LIBS = $(am__append_192) $(am__append_194) +diff -urp libvirt-5.3.0.orig/src/qemu/qemu.conf libvirt-5.3.0/src/qemu/qemu.conf +--- libvirt-5.3.0.orig/src/qemu/qemu.conf 2019-05-04 19:50:45.015543968 +0200 ++++ libvirt-5.3.0/src/qemu/qemu.conf 2019-05-06 14:07:53.498000000 +0200 +@@ -135,18 +135,18 @@ # Examples include vinagre, virt-viewer and virt-manager # itself. UltraVNC, RealVNC, TightVNC do not support this # @@ -68,7 +59,7 @@ diff -urp libvirt-4.5.0.orig/src/qemu/qemu.conf libvirt-4.5.0/src/qemu/qemu.conf # QEMU implements an extension for providing audio over a VNC connection, -@@ -205,17 +205,17 @@ +@@ -211,17 +211,17 @@ # Enable use of SASL encryption on the SPICE server. This requires # a SPICE client which supports the SASL protocol extension. # @@ -89,10 +80,10 @@ diff -urp libvirt-4.5.0.orig/src/qemu/qemu.conf libvirt-4.5.0/src/qemu/qemu.conf # Enable use of TLS encryption on the chardev TCP transports. # -diff -urp libvirt-4.5.0.orig/src/qemu/test_libvirtd_qemu.aug.in libvirt-4.5.0/src/qemu/test_libvirtd_qemu.aug.in ---- libvirt-4.5.0.orig/src/qemu/test_libvirtd_qemu.aug.in 2018-07-09 16:24:49.520875581 +0000 -+++ libvirt-4.5.0/src/qemu/test_libvirtd_qemu.aug.in 2018-07-09 16:25:07.312874521 +0000 -@@ -12,7 +12,7 @@ module Test_libvirtd_qemu = +diff -urp libvirt-5.3.0.orig/src/qemu/test_libvirtd_qemu.aug.in libvirt-5.3.0/src/qemu/test_libvirtd_qemu.aug.in +--- libvirt-5.3.0.orig/src/qemu/test_libvirtd_qemu.aug.in 2019-02-26 00:24:59.030183057 +0100 ++++ libvirt-5.3.0/src/qemu/test_libvirtd_qemu.aug.in 2019-05-06 14:07:53.498000000 +0200 +@@ -13,7 +13,7 @@ module Test_libvirtd_qemu = { "vnc_tls_x509_verify" = "1" } { "vnc_password" = "XYZ12345" } { "vnc_sasl" = "1" } @@ -101,7 +92,7 @@ diff -urp libvirt-4.5.0.orig/src/qemu/test_libvirtd_qemu.aug.in libvirt-4.5.0/sr { "vnc_allow_host_audio" = "0" } { "spice_listen" = "0.0.0.0" } { "spice_tls" = "1" } -@@ -20,7 +20,7 @@ module Test_libvirtd_qemu = +@@ -21,7 +21,7 @@ module Test_libvirtd_qemu = { "spice_auto_unix_socket" = "1" } { "spice_password" = "XYZ12345" } { "spice_sasl" = "1" } @@ -110,9 +101,9 @@ diff -urp libvirt-4.5.0.orig/src/qemu/test_libvirtd_qemu.aug.in libvirt-4.5.0/sr { "chardev_tls" = "1" } { "chardev_tls_x509_cert_dir" = "/etc/pki/libvirt-chardev" } { "chardev_tls_x509_verify" = "1" } -diff -urp libvirt-4.5.0.orig/src/remote/libvirtd.conf libvirt-4.5.0/src/remote/libvirtd.conf ---- libvirt-4.5.0.orig/src/remote/libvirtd.conf 2018-07-09 16:24:49.523875581 +0000 -+++ libvirt-4.5.0/src/remote/libvirtd.conf 2018-07-09 16:25:07.312874521 +0000 +diff -urp libvirt-5.3.0.orig/src/remote/libvirtd.conf libvirt-5.3.0/src/remote/libvirtd.conf +--- libvirt-5.3.0.orig/src/remote/libvirtd.conf 2019-04-27 12:31:34.943092025 +0200 ++++ libvirt-5.3.0/src/remote/libvirtd.conf 2019-05-06 14:07:53.498000000 +0200 @@ -123,7 +123,7 @@ # the network providing auth (eg, TLS/x509 certificates) # @@ -131,30 +122,21 @@ diff -urp libvirt-4.5.0.orig/src/remote/libvirtd.conf libvirt-4.5.0/src/remote/l #auth_tcp = "sasl" # Change the authentication scheme for TLS sockets. -diff -urp libvirt-4.5.0.orig/src/remote/Makefile.inc.am libvirt-4.5.0/src/remote/Makefile.inc.am ---- libvirt-4.5.0.orig/src/remote/Makefile.inc.am 2018-07-09 16:24:49.520875581 +0000 -+++ libvirt-4.5.0/src/remote/Makefile.inc.am 2018-07-09 16:25:07.312874521 +0000 -@@ -248,13 +248,13 @@ endif ! WITH_LIBVIRTD +diff -urp libvirt-5.3.0.orig/src/remote/Makefile.inc.am libvirt-5.3.0/src/remote/Makefile.inc.am +--- libvirt-5.3.0.orig/src/remote/Makefile.inc.am 2019-04-27 12:31:34.942092034 +0200 ++++ libvirt-5.3.0/src/remote/Makefile.inc.am 2019-05-06 14:07:53.498000000 +0200 +@@ -244,7 +244,7 @@ endif WITH_LIBVIRTD + # This is needed for clients too, so can't wrap in # the WITH_LIBVIRTD conditional if WITH_SASL - install-sasl: -- $(MKDIR_P) $(DESTDIR)$(sysconfdir)/sasl2/ -+ $(MKDIR_P) $(DESTDIR)$(sysconfdir)/sasl/ - $(INSTALL_DATA) $(srcdir)/remote/libvirtd.sasl \ -- $(DESTDIR)$(sysconfdir)/sasl2/libvirt.conf -+ $(DESTDIR)$(sysconfdir)/sasl/libvirt.conf +-sasldir = $(sysconfdir)/sasl2 ++sasldir = $(sysconfdir)/sasl - uninstall-sasl: -- rm -f $(DESTDIR)$(sysconfdir)/sasl2/libvirt.conf -- rmdir $(DESTDIR)$(sysconfdir)/sasl2/ || : -+ rm -f $(DESTDIR)$(sysconfdir)/sasl/libvirt.conf -+ rmdir $(DESTDIR)$(sysconfdir)/sasl/ || : - else ! WITH_SASL install-sasl: - uninstall-sasl: -diff -urp libvirt-4.5.0.orig/tests/qemuargv2xmldata/graphics-vnc-sasl.args libvirt-4.5.0/tests/qemuargv2xmldata/graphics-vnc-sasl.args ---- libvirt-4.5.0.orig/tests/qemuargv2xmldata/graphics-vnc-sasl.args 2018-07-09 16:24:50.006875552 +0000 -+++ libvirt-4.5.0/tests/qemuargv2xmldata/graphics-vnc-sasl.args 2018-07-09 16:25:07.312874521 +0000 + $(MKDIR_P) $(DESTDIR)$(sasldir) +diff -urp libvirt-5.3.0.orig/tests/qemuargv2xmldata/graphics-vnc-sasl.args libvirt-5.3.0/tests/qemuargv2xmldata/graphics-vnc-sasl.args +--- libvirt-5.3.0.orig/tests/qemuargv2xmldata/graphics-vnc-sasl.args 2018-01-12 15:48:37.072414510 +0100 ++++ libvirt-5.3.0/tests/qemuargv2xmldata/graphics-vnc-sasl.args 2019-05-06 14:07:53.499000000 +0200 @@ -3,7 +3,7 @@ PATH=/bin \ HOME=/home/test \ USER=test \ @@ -164,9 +146,9 @@ diff -urp libvirt-4.5.0.orig/tests/qemuargv2xmldata/graphics-vnc-sasl.args libvi QEMU_AUDIO_DRV=none \ /usr/bin/qemu-system-i686 \ -name QEMUGuest1 \ -diff -urp libvirt-4.5.0.orig/tests/qemuargv2xmldata/graphics-vnc-tls.args libvirt-4.5.0/tests/qemuargv2xmldata/graphics-vnc-tls.args ---- libvirt-4.5.0.orig/tests/qemuargv2xmldata/graphics-vnc-tls.args 2018-07-09 16:24:50.006875552 +0000 -+++ libvirt-4.5.0/tests/qemuargv2xmldata/graphics-vnc-tls.args 2018-07-09 16:25:07.312874521 +0000 +diff -urp libvirt-5.3.0.orig/tests/qemuargv2xmldata/graphics-vnc-tls.args libvirt-5.3.0/tests/qemuargv2xmldata/graphics-vnc-tls.args +--- libvirt-5.3.0.orig/tests/qemuargv2xmldata/graphics-vnc-tls.args 2018-01-12 15:48:37.073414500 +0100 ++++ libvirt-5.3.0/tests/qemuargv2xmldata/graphics-vnc-tls.args 2019-05-06 14:07:53.499000000 +0200 @@ -3,7 +3,7 @@ PATH=/bin \ HOME=/home/test \ USER=test \ @@ -176,46 +158,46 @@ diff -urp libvirt-4.5.0.orig/tests/qemuargv2xmldata/graphics-vnc-tls.args libvir QEMU_AUDIO_DRV=none \ /usr/bin/qemu-system-i686 \ -name QEMUGuest1 \ -diff -urp libvirt-4.5.0.orig/tests/qemuxml2argvdata/graphics-spice-sasl.args libvirt-4.5.0/tests/qemuxml2argvdata/graphics-spice-sasl.args ---- libvirt-4.5.0.orig/tests/qemuxml2argvdata/graphics-spice-sasl.args 2018-07-09 16:24:49.567875579 +0000 -+++ libvirt-4.5.0/tests/qemuxml2argvdata/graphics-spice-sasl.args 2018-07-09 16:25:07.312874521 +0000 -@@ -3,7 +3,7 @@ PATH=/bin \ - HOME=/home/test \ - USER=test \ - LOGNAME=test \ +diff -urp libvirt-5.3.0.orig/tests/qemuxml2argvdata/graphics-spice-sasl.args libvirt-5.3.0/tests/qemuxml2argvdata/graphics-spice-sasl.args +--- libvirt-5.3.0.orig/tests/qemuxml2argvdata/graphics-spice-sasl.args 2019-04-27 12:31:35.106090528 +0200 ++++ libvirt-5.3.0/tests/qemuxml2argvdata/graphics-spice-sasl.args 2019-05-06 14:08:46.241000000 +0200 +@@ -6,7 +6,7 @@ LOGNAME=test \ + XDG_DATA_HOME=/tmp/lib/domain--1-QEMUGuest1/.local/share \ + XDG_CACHE_HOME=/tmp/lib/domain--1-QEMUGuest1/.cache \ + XDG_CONFIG_HOME=/tmp/lib/domain--1-QEMUGuest1/.config \ -SASL_CONF_PATH=/root/.sasl2 \ +SASL_CONF_PATH=/root/.sasl \ QEMU_AUDIO_DRV=spice \ /usr/bin/qemu-system-i686 \ -name QEMUGuest1 \ -diff -urp libvirt-4.5.0.orig/tests/qemuxml2argvdata/graphics-vnc-sasl.args libvirt-4.5.0/tests/qemuxml2argvdata/graphics-vnc-sasl.args ---- libvirt-4.5.0.orig/tests/qemuxml2argvdata/graphics-vnc-sasl.args 2018-07-09 16:24:49.567875579 +0000 -+++ libvirt-4.5.0/tests/qemuxml2argvdata/graphics-vnc-sasl.args 2018-07-09 16:25:07.312874521 +0000 -@@ -3,7 +3,7 @@ PATH=/bin \ - HOME=/home/test \ - USER=test \ - LOGNAME=test \ +diff -urp libvirt-5.3.0.orig/tests/qemuxml2argvdata/graphics-vnc-sasl.args libvirt-5.3.0/tests/qemuxml2argvdata/graphics-vnc-sasl.args +--- libvirt-5.3.0.orig/tests/qemuxml2argvdata/graphics-vnc-sasl.args 2019-04-27 12:31:35.108090510 +0200 ++++ libvirt-5.3.0/tests/qemuxml2argvdata/graphics-vnc-sasl.args 2019-05-06 14:08:24.446000000 +0200 +@@ -6,7 +6,7 @@ LOGNAME=test \ + XDG_DATA_HOME=/tmp/lib/domain--1-QEMUGuest1/.local/share \ + XDG_CACHE_HOME=/tmp/lib/domain--1-QEMUGuest1/.cache \ + XDG_CONFIG_HOME=/tmp/lib/domain--1-QEMUGuest1/.config \ -SASL_CONF_PATH=/root/.sasl2 \ +SASL_CONF_PATH=/root/.sasl \ QEMU_AUDIO_DRV=none \ /usr/bin/qemu-system-i686 \ -name QEMUGuest1 \ -diff -urp libvirt-4.5.0.orig/tests/qemuxml2argvdata/graphics-vnc-tls.args libvirt-4.5.0/tests/qemuxml2argvdata/graphics-vnc-tls.args ---- libvirt-4.5.0.orig/tests/qemuxml2argvdata/graphics-vnc-tls.args 2018-07-09 16:24:49.567875579 +0000 -+++ libvirt-4.5.0/tests/qemuxml2argvdata/graphics-vnc-tls.args 2018-07-09 16:25:07.313874521 +0000 -@@ -3,7 +3,7 @@ PATH=/bin \ - HOME=/home/test \ - USER=test \ - LOGNAME=test \ +diff -urp libvirt-5.3.0.orig/tests/qemuxml2argvdata/graphics-vnc-tls.args libvirt-5.3.0/tests/qemuxml2argvdata/graphics-vnc-tls.args +--- libvirt-5.3.0.orig/tests/qemuxml2argvdata/graphics-vnc-tls.args 2019-04-27 12:31:35.109090500 +0200 ++++ libvirt-5.3.0/tests/qemuxml2argvdata/graphics-vnc-tls.args 2019-05-06 14:08:33.926000000 +0200 +@@ -6,7 +6,7 @@ LOGNAME=test \ + XDG_DATA_HOME=/tmp/lib/domain--1-QEMUGuest1/.local/share \ + XDG_CACHE_HOME=/tmp/lib/domain--1-QEMUGuest1/.cache \ + XDG_CONFIG_HOME=/tmp/lib/domain--1-QEMUGuest1/.config \ -SASL_CONF_PATH=/root/.sasl2 \ +SASL_CONF_PATH=/root/.sasl \ QEMU_AUDIO_DRV=none \ /usr/bin/qemu-system-i686 \ -name QEMUGuest1 \ -diff -urp libvirt-4.5.0.orig/tests/qemuxml2argvtest.c libvirt-4.5.0/tests/qemuxml2argvtest.c ---- libvirt-4.5.0.orig/tests/qemuxml2argvtest.c 2018-07-09 16:24:49.831875563 +0000 -+++ libvirt-4.5.0/tests/qemuxml2argvtest.c 2018-07-09 16:25:07.313874521 +0000 -@@ -1190,7 +1190,7 @@ mymain(void) +diff -urp libvirt-5.3.0.orig/tests/qemuxml2argvtest.c libvirt-5.3.0/tests/qemuxml2argvtest.c +--- libvirt-5.3.0.orig/tests/qemuxml2argvtest.c 2019-04-27 12:31:35.156090069 +0200 ++++ libvirt-5.3.0/tests/qemuxml2argvtest.c 2019-05-06 14:07:53.502000000 +0200 +@@ -1145,7 +1145,7 @@ mymain(void) driver.config->vncSASL = 1; VIR_FREE(driver.config->vncSASLdir); @@ -224,7 +206,7 @@ diff -urp libvirt-4.5.0.orig/tests/qemuxml2argvtest.c libvirt-4.5.0/tests/qemuxm DO_TEST("graphics-vnc-sasl", QEMU_CAPS_VNC, QEMU_CAPS_DEVICE_CIRRUS_VGA); driver.config->vncTLS = 1; driver.config->vncTLSx509verify = 1; -@@ -1210,7 +1210,7 @@ mymain(void) +@@ -1177,7 +1177,7 @@ mymain(void) DO_TEST("graphics-spice-no-args", QEMU_CAPS_SPICE, QEMU_CAPS_DEVICE_CIRRUS_VGA); driver.config->spiceSASL = 1; @@ -233,9 +215,9 @@ diff -urp libvirt-4.5.0.orig/tests/qemuxml2argvtest.c libvirt-4.5.0/tests/qemuxm DO_TEST("graphics-spice-sasl", QEMU_CAPS_SPICE, QEMU_CAPS_DEVICE_QXL); -diff -urp libvirt-4.5.0.orig/tests/virconfdata/libvirtd.conf libvirt-4.5.0/tests/virconfdata/libvirtd.conf ---- libvirt-4.5.0.orig/tests/virconfdata/libvirtd.conf 2018-07-09 16:24:49.818875564 +0000 -+++ libvirt-4.5.0/tests/virconfdata/libvirtd.conf 2018-07-09 16:25:07.313874521 +0000 +diff -urp libvirt-5.3.0.orig/tests/virconfdata/libvirtd.conf libvirt-5.3.0/tests/virconfdata/libvirtd.conf +--- libvirt-5.3.0.orig/tests/virconfdata/libvirtd.conf 2017-10-30 08:32:36.772365929 +0100 ++++ libvirt-5.3.0/tests/virconfdata/libvirtd.conf 2019-05-06 14:07:53.502000000 +0200 @@ -108,7 +108,7 @@ unix_sock_admin_perms = "0700" # the network providing auth (eg, TLS/x509 certificates) # @@ -254,9 +236,9 @@ diff -urp libvirt-4.5.0.orig/tests/virconfdata/libvirtd.conf libvirt-4.5.0/tests auth_tcp = "sasl" # Change the authentication scheme for TLS sockets. -diff -urp libvirt-4.5.0.orig/tests/virconfdata/libvirtd.out libvirt-4.5.0/tests/virconfdata/libvirtd.out ---- libvirt-4.5.0.orig/tests/virconfdata/libvirtd.out 2018-07-09 16:24:49.818875564 +0000 -+++ libvirt-4.5.0/tests/virconfdata/libvirtd.out 2018-07-09 16:25:07.313874521 +0000 +diff -urp libvirt-5.3.0.orig/tests/virconfdata/libvirtd.out libvirt-5.3.0/tests/virconfdata/libvirtd.out +--- libvirt-5.3.0.orig/tests/virconfdata/libvirtd.out 2017-10-30 08:32:36.772365929 +0100 ++++ libvirt-5.3.0/tests/virconfdata/libvirtd.out 2019-05-06 14:07:53.502000000 +0200 @@ -87,7 +87,7 @@ unix_sock_admin_perms = "0700" # the network providing auth (eg, TLS/x509 certificates) #