X-Git-Url: https://git.tld-linux.org/?p=rc-scripts.git;a=blobdiff_plain;f=lib%2Ffunctions;h=fb41ffa17f86c6ee922679bc64e1bf5dd04151cc;hp=fac4c46e67cfccdca16a3f8369cbc08f803ce7c8;hb=49ade4f4b5b1978db4561d62063008a339a1526f;hpb=2d25be2988d266692b556fbcc89c5b9108cf16f8

diff --git a/lib/functions b/lib/functions
index fac4c46..fb41ffa 100644
--- a/lib/functions
+++ b/lib/functions
@@ -605,16 +605,90 @@ _daemon_set_ulimits() {
 	done
 }
 
+# inner function used by daemon().
+# do not call this directly, as it expects variables being inherited.
+# also it expects to be called from subshell as it exports env.
+# it expects options parsed by daemon() and command to be executed in "$@".
+_daemon_exec() {
+	local prog=""
+	umask ${SERVICE_UMASK:-$DEFAULT_SERVICE_UMASK};
+	export USER=root HOME=/tmp TMPDIR=/tmp
+
+	nice=${nice:-$DEFAULT_SERVICE_RUN_NICE_LEVEL}
+	nice=${nice:-0}
+
+	# make nice level absolute, not to be dependant of nice level of shell where service started
+	nice=$(($nice - $(nice)))
+
+	if [ "$closefds" = 1 ]; then
+		exec 1>&-
+		exec 2>&-
+		exec 0<&-
+	elif [ "$redirfds" = 1 ]; then
+		exec 1>/dev/null
+		exec 2>/dev/null
+		exec 0</dev/null
+	else
+		exec 2>&1
+		exec 0</dev/null
+	fi
+
+	if is_no "$RC_LOGGING"; then
+		prog=$1; shift
+		if [ ! -x $prog ]; then
+			logger -t rc-scripts -p daemon.debug "daemon: Searching PATH for $prog, consider using full path in initscript"
+			local a o=$IFS
+			IFS=:
+			for a in $PATH; do
+				if [ -x $a/$prog ]; then
+					prog=$a/$prog
+					break
+				fi
+			done
+			IFS=$o
+		fi
+		set -- "$prog" "$@"
+
+		# use setsid to detach from terminal,
+		# NOTE: setsid needs to be "outer" program
+		# otherwise start-stop-daemon would capture the setsid pid not the actual program
+
+		prog=$1; shift
+		/usr/bin/setsid \
+		/sbin/start-stop-daemon -q --start \
+			--nicelevel $nice \
+			${pidfile:+--pidfile $pidfile} \
+			${makepid:+--make-pidfile} \
+			${user:+--chuid $user} \
+			${chdir:+--chdir "$chdir"} \
+			${fork:+--background} \
+			${SERVICE_DROPCAPS:+--dropcap $SERVICE_DROPCAPS} \
+			--exec "$prog" \
+			-- "$@"
+	else
+		if [ "$fork" = "1" ]; then
+			export PIDFILE="/dev/null"
+			if [ "$makepid" ] && [ "$pidfile" ]; then
+				export PIDFILE="$pidfile"
+			fi
+			set -- /lib/rc-scripts/makepid "$@"
+			set -- /usr/bin/setsid "$@"
+		fi
+		if [ -n "$user" -a "$user" != "root" ]; then
+			set -- /bin/runuser -u "$user" -- "$@"
+		fi
+
+		nice -n $nice initlog -c "$*" 2>&1 </dev/null
+	fi
+}
+
 # A function to start a program (now it's useful on read-only filesystem too)
 daemon() {
-	local errors="" prog="" end="" waitname="" waittime=0
+	local errors="" waitname="" waittime=0
 	local exit_code=0
 	local nice=$SERVICE_RUN_NICE_LEVEL
 	local fork user closefds redirfds pidfile makepid chdir=/
 
-	# NOTE: if you wonder how the shellish (by syntax) $prog works in ssd mode,
-	# then the answer is: it totally ignores $prog and uses "$@" itself.
-
 	while [ $# -gt 0 ]; do
 		case $1 in
 		'')
@@ -632,7 +706,6 @@ daemon() {
 			;;
 		--fork)
 			fork=1
-			end='&'
 			;;
 		--chdir)
 			shift
@@ -663,6 +736,8 @@ daemon() {
 			;;
 		--makepid)
 			makepid=1
+			# makepid implies fork
+			fork=1
 			;;
 		-*|+*)
 			nice=$1
@@ -675,19 +750,6 @@ daemon() {
 		esac
 		shift
 	done
-	if [ -n "$user" -a "$user" != "root" ]; then
-		prog="/bin/su $user -s /bin/sh -c \""
-	fi
-	if [ "$fork" = "1" ]; then
-		prog="/usr/bin/setsid ${prog:-sh -c \"}"
-	fi
-	# If command to execute ends with quotation mark, add remaining
-	# arguments and close quotation.
-	if [ "$prog" != "${prog%\"}" ]; then
-		prog="$prog $*$end\""
-	else
-		prog="$prog $*$end"
-	fi
 
 	_daemon_set_ulimits
 
@@ -698,67 +760,7 @@ daemon() {
 	busy
 	cd $chdir
 	[ -n "$SERVICE_CPUSET" ] && is_yes "$CPUSETS" && echo $$ > "/dev/cpuset/${SERVICE_CPUSET}/tasks"
-	if errors=$(
-		umask ${SERVICE_UMASK:-$DEFAULT_SERVICE_UMASK};
-		export USER=root HOME=/tmp TMPDIR=/tmp
-
-		nice=${nice:-$DEFAULT_SERVICE_RUN_NICE_LEVEL}
-		nice=${nice:-0}
-
-		# make nice level absolute, not to be dependant of nice level of shell where service started
-		nice=$(($nice - $(nice)))
-
-		if [ "$closefds" = 1 ]; then
-			exec 1>&-
-			exec 2>&-
-			exec 0<&-
-		elif [ "$redirfds" = 1 ]; then
-			exec 1>/dev/null
-			exec 2>/dev/null
-			exec 0</dev/null
-		else
-			exec 2>&1
-			exec 0</dev/null
-		fi
-
-		if is_no "$RC_LOGGING"; then
-			prog=$1; shift
-			if [ ! -x $prog ]; then
-				logger -t rc-scripts -p daemon.debug "daemon: Searching PATH for $prog, consider using full path in initscript"
-				local a o=$IFS
-				IFS=:
-				for a in $PATH; do
-					if [ -x $a/$prog ]; then
-						prog=$a/$prog
-						break
-					fi
-				done
-				IFS=$o
-			fi
-			set -- "$prog" "$@"
-
-			# use setsid to detach from terminal,
-			# needs pidfile or ssd would check setsid program instead of real program
-			if [ "$pidfile" ]; then
-				set -- /usr/bin/setsid "$@"
-			fi
-
-			prog=$1; shift
-			/sbin/start-stop-daemon -q --start \
-				--nicelevel $nice \
-				${pidfile:+--pidfile $pidfile} \
-				${makepid:+--make-pidfile} \
-				${user:+--chuid $user} \
-				${chdir:+--chdir "$chdir"} \
-				${fork:+--background} \
-				${SERVICE_DROPCAPS:+--dropcap $SERVICE_DROPCAPS} \
-				--exec "$prog" \
-				-- "$@"
-		else
-			nice -n $nice initlog -c "$prog" 2>&1 </dev/null
-		fi
-		); then
-
+	if errors=$(_daemon_exec "$@"); then
 		# wait for process (or pidfile) to be created
 		if [ "$waittime" -gt 0 ]; then
 			# waitname can be empty, as if pidfile is in use, it is not relevant
@@ -984,7 +986,7 @@ pidofproc() {
 	fi
 
 	# Next try "pidof" if pidfile is not specified
-	if [ -z "$pid" ] && [ -z "$pidfile" ]; then
+	if [ -z "$pid" ] && [ -z "$2" ]; then
 		pid=$(pidof -o $$ -o $PPID -o %PPID -x "$1")
 	fi